Add Windows installation #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## sdf9 #463 +/- ##
=======================================
Coverage 86.68% 86.68%
=======================================
Files 61 61
Lines 9516 9516
=======================================
Hits 8249 8249
Misses 1267 1267 Continue to review full report at Codecov.
|
Signed-off-by: Mabel Zhang <[email protected]>
JShep1
approved these changes
Jan 20, 2021
Yes I believe it's an optional dependency. Also, my approval doesn't have the permissions to approve merging, perhaps @chapulina or @scpeters can help here? |
Signed-off-by: Mabel Zhang <[email protected]>
|
Just fixed typo. Yeah I don't have write access here to merge either. |
chapulina
reviewed
Jan 21, 2021
Signed-off-by: Mabel Zhang <[email protected]>
Signed-off-by: Mabel Zhang <[email protected]>
chapulina
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retarget of #451 to sdf9 for Citadel via cherry-pick.
Plus standardize tutorial to be uniform with ign-common.
Copy of description:
Partially addresses gazebosim/docs#117
Is
ignition-toolsan optional dependency? I saw a warning in CMake but didn’t see it in CMakeLists.txt.@JShep1 @chapulina